Add the filter parameter #5978
Add the filter parameter #5978
Conversation
|
This PR is pretty rough. The 'processGQLResult' function is basically a hack, in much the same way that 'knexify' inside of GQL is also a hack. I'm in no way suggesting that these are a good long term basis, however they get us to a state where a large part of the functionality is 'working'. My idea is to get this merged quickly, and then iterate on improving the various areas of both GQL and the wiring in Ghost, solving problems one at a time, rather than getting stuck trying to make everything work perfectly all at once 😁 With this merged, other work can start to replace the code in Ghost which depends on the old style parameters, and then they can be removed :) |
refs TryGhost#5604, refs TryGhost#5463 - deps: [email protected] - adds code to wire up the filtering to a paginated query - updated pagination plugin count query to use 'distinct' so it's more robust - rename paginationUtils.query to addLimitAndOffset to be more explicit and make the code clearer - add a new 'advanced browsing spec' set of tests for tracking these features as they are built out
|
I have just updated GQL so that it has the same lodash version as Ghost: https://github.com/TryGhost/GQL/releases/tag/0.0.2 This PR now references [email protected] I've also rebased this against latest master - it's should be mergable. |
refs #5604, refs #5463