metadata: One-line TraverseFiles to parse #defines from dstorageerr.h
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…err.h` Some manual fiddling with `generate.proj` showed to me that only the first file in `TraverseFiles` was getting considered for constants scraping. There doesn't appear to be a `.Trim()` call on the string parsing in `WinmdGenerator` source code, likely causing the last entry to end with `\n` which won't match a file name. Simply changing how `TraverseFiles` is specified in the project file XML allows us to remove the manual definitions of these constants entirely again.
This was referenced Jan 29, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some manual fiddling with
generate.projshowed to me that only the first file inTraverseFileswas getting considered for constants scraping. There doesn't appear to be a.Trim()call on the string parsing inWinmdGeneratorsource code, likely causing the last entry to end with\nwhich won't match a file name. Simply changing howTraverseFilesis specified in the project file XML allows us to remove the manual definitions of these constants entirely again.