strip dots from method names

Tucker-Eric · Jun 12, 2018 · 1368bea · 1368bea
1 parent cdf78b8
commit 1368bea
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/ModelFilter.php b/src/ModelFilter.php
@@ -185,7 +185,7 @@ public function related($relation, $column, $operator = null, $value = null, $bo
      */
     public function getFilterMethod($key)
     {
-        return camel_case($this->drop_id ? preg_replace('/^(.*)_id$/', '$1', $key) : $key);
+        return camel_case(str_replace('.', '', $this->drop_id ? preg_replace('/^(.*)_id$/', '$1', $key) : $key));
     }
 
     /**

diff --git a/tests/ModelFilterTest.php b/tests/ModelFilterTest.php
@@ -114,6 +114,9 @@ public function testGetFilterMethod()
             'name'               => 'name',
             'first_name'         => 'firstName',
             'first_or_last_name' => 'firstOrLastName',
+            // Test dot-notation works
+            'Company.Name'       => 'companyName',
+            'Company-Name'       => 'companyName'
         ];
 
         foreach ($input as $key => $method) {
-Original file line number
+Diff line change
@@ Expand Up @@
          */
         public function getFilterMethod($key)
         {
-            return camel_case($this->drop_id ? preg_replace('/^(.*)_id$/', '$1', $key) : $key);
+            return camel_case(str_replace('.', '', $this->drop_id ? preg_replace('/^(.*)_id$/', '$1', $key) : $key));
         }
         /**
@@ Expand Down @@