Bump min SDK version to 23 (#318)

* Make CombineLatestWithLog compatible with earlier API

* Fix launcher icons on earlier API versions

* Bump min SDK version to 23

* Add changelog entry

* Mention fixed icon in changelog

Co-authored-by: Łukasz Rutkowski <[email protected]>

CHANGELOG.md

@@ -10,9 +10,14 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 -   Support for reddit galleries ([#312](https://github.com/Tunous/Dawn/pull/312))
 
+### Changed
+
+-   Increased minimum required API version to 23 ([#318](https://github.com/Tunous/Dawn/pull/318))
+
 ### Fixed
 
--   Correctly parse links with leading/trailing spaces ([319](https://github.com/Tunous/Dawn/pull/319))
+-   Correctly parse links with leading/trailing spaces ([#319](https://github.com/Tunous/Dawn/pull/319))
+-   App icon on API versions lower than 26 ([#318](https://github.com/Tunous/Dawn/pull/318))
 
 ## [0.10.0] - 2020-08-14
 

app/src/main/AndroidManifest.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest package="me.saket.dank"
-  xmlns:android="http://schemas.android.com/apk/res/android">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+  package="me.saket.dank">
 
   <uses-permission android:name="android.permission.INTERNET" />
 
@@ -18,8 +18,9 @@
     android:allowBackup="true"
     android:icon="@mipmap/ic_launcher"
     android:label="@string/app_launcher_label"
-    android:supportsRtl="true"
     android:networkSecurityConfig="@xml/network_security_config"
+    android:roundIcon="@mipmap/ic_launcher_round"
+    android:supportsRtl="true"
     android:theme="@style/DankTheme.TransparentBackground">
 
     <activity-alias

app/src/main/java/me/saket/dank/utils/CombineLatestWithLog.java

@@ -1,8 +1,6 @@
 package me.saket.dank.utils;
 
 import android.annotation.SuppressLint;
-import android.annotation.TargetApi;
-import android.os.Build;
 
 import com.google.auto.value.AutoValue;
 
@@ -21,7 +19,6 @@
 import timber.log.Timber;
 
 @SuppressLint("UseSparseArrays")
-@TargetApi(Build.VERSION_CODES.N)
 public class CombineLatestWithLog {
 
   @AutoValue
@@ -68,12 +65,13 @@ public <T> ObservableTransformer<T, T> print() {
 
         if (needsLog) {
           Timber.w("------------------------------------------------");
-          items.forEach((name, item) -> {
+          for (Map.Entry<String, Object> item: items.entrySet()) {
+            String name = item.getKey();
             if (delays.get(name) > threshold) {
               Timber.w("%s = %sms [SLOW]", name, delays.get(name));
               Timber.w("Time since subscribe: %s", (endTimes.get(name) - subscribeTimes.get(name)));
             }
-          });
+          }
           Timber.i("------------------------------------------------");
         }
       }));

build.gradle

@@ -2,7 +2,7 @@ import org.gradle.api.tasks.wrapper.Wrapper.DistributionType
 
 buildscript {
   ext.versions = [
-      minSdk          : 21,
+      minSdk          : 23,
       compileSdk      : 28,
       supportLib      : '28.0.0',
       glide           : '4.11.0',