This repository was archived by the owner on Jun 9, 2023. It is now read-only.
Long click options menu for in-text links #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saket
reviewed
Jan 13, 2019
| @Override | ||
| public boolean onTouchEvent(TextView view, Spannable text, MotionEvent event) { | ||
| if (event.getAction() == MotionEvent.ACTION_UP) { | ||
| // A link is potentially going to be clicked. | ||
| clickedUrlCoordinates = new Point((int) event.getRawX(), (int) event.getRawY()); | ||
| } else if (event.getAction() == MotionEvent.ACTION_DOWN) { | ||
| touchCoordinates = new Point((int) event.getRawX(), (int) event.getRawY()); |
There was a problem hiding this comment.
Can clickedUrlCoordinates not be used here?
There was a problem hiding this comment.
Hmm good point, didn't think of that. I guess it should work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes all in-text links display options menu when long clicked.