Skip to content
This repository was archived by the owner on Jun 9, 2023. It is now read-only.

Upgrade Gradle to 6.2.1 #152

Merged
merged 5 commits into from
Apr 29, 2020
Merged

Conversation

msfjarvis
Copy link
Collaborator

Also removed the hardcoded version in build.gradle to avoid unnecessary diff churn when upgrading.

@msfjarvis
Copy link
Collaborator Author

I can't add the verification task through a PR, but here's the commit for you to cherry-pick to master before merging this.

@Tunous Tunous added the dependencies Pull requests that update a dependency label Jan 25, 2020
@msfjarvis msfjarvis changed the title Upgrade Gradle to 6.1 Upgrade Gradle to 6.2.1 Feb 25, 2020
@Tunous Tunous self-assigned this Apr 27, 2020
@Tunous Tunous force-pushed the refactor/upgrade-gradle branch from ff04147 to 992d4bb Compare April 29, 2020 17:21
@Tunous Tunous merged commit 7b0af7d into Tunous:master Apr 29, 2020
@msfjarvis
Copy link
Collaborator Author

Well, I was 5 seconds away from updating the branch for Gradle 6.3. I've done that anyway now, so you can probably just pick this to master or I can start a new PR as per your preference.

@Tunous
Copy link
Owner

Tunous commented Apr 29, 2020

One thing I've noticed (based on https://gitlab.com/fdroid/rfp/-/issues/1320#note_331543140) is that we are missing distributionSha256Sum from properties. Would you be able to make a pull request which also includes required correct checksum?

@msfjarvis
Copy link
Collaborator Author

One thing I've noticed (based on gitlab.com/fdroid/rfp/-/issues/1320#note_331543140) is that we are missing distributionSha256Sum from properties. Would you be able to make a pull request which also includes required correct checksum?

Sure, I'll check what needs to be configured to add it automatically.

@msfjarvis
Copy link
Collaborator Author

Turns out that it cannot be added automatically, because Gradle makes this manual and explicit, and F-Droid being F-Droid bumps the responsibility to downstream app developers rather than attempt to automate it on their end which would actually be rather simple. I'll add it manually for now and just take care going forward to keep doing it by hand.

@Tunous Tunous added this to the 0.9.0 milestone Apr 30, 2020
msfjarvis added a commit to msfjarvis/Dawn that referenced this pull request Aug 5, 2020
…jarvis/swipe-gesture-icon-position' into features

* msfjarvis/multiple_accounts: (24 commits)
  Adds multiple accounts support
  Prepare next version
  Update changelog for 0.9.1 (Tunous#198)
  Force logout all users (Tunous#196)
  Handle exceptions while opening a browser (Tunous#108) (Tunous#193)
  Prevent selection of negative ranges in SelectionLimitingTextView (fixes Tunous#190) (Tunous#194)
  Prepare next version
  Release 0.9.0 (Tunous#184)
  Release workflow (Tunous#185)
  Fix image loading issues due to http urls (Tunous#183)
  Selftext selection (Tunous#178)
  Submission title selection (Tunous#182)
  Update changelog with missed changes
  Wrap comment byline when it is too long to fit in one line (Tunous#145)
  Revert "Run Debug workflow only on push"
  Upgrade to Gradle 6.3 and add checksum field for F-Droid (Tunous#180)
  Run Debug workflow only on push
  Upgrade Gradle to 6.2.1 (Tunous#152)
  Use GitHub Actions (#72)
  Switch to on-device link unfurler (Tunous#138)
  ...

* msfjarvis/swipe-gesture-icon-position: (26 commits)
  Return false to keep the touch flow going
  Make the gestures' icons follow touch event position on Y
  Swipe Actions' icons at same level as touch event
  Prepare next version
  Update changelog for 0.9.1 (Tunous#198)
  Force logout all users (Tunous#196)
  Handle exceptions while opening a browser (Tunous#108) (Tunous#193)
  Prevent selection of negative ranges in SelectionLimitingTextView (fixes Tunous#190) (Tunous#194)
  Prepare next version
  Release 0.9.0 (Tunous#184)
  Release workflow (Tunous#185)
  Fix image loading issues due to http urls (Tunous#183)
  Selftext selection (Tunous#178)
  Submission title selection (Tunous#182)
  Update changelog with missed changes
  Wrap comment byline when it is too long to fit in one line (Tunous#145)
  Revert "Run Debug workflow only on push"
  Upgrade to Gradle 6.3 and add checksum field for F-Droid (Tunous#180)
  Run Debug workflow only on push
  Upgrade Gradle to 6.2.1 (Tunous#152)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants