Skip to content
This repository was archived by the owner on Jun 9, 2023. It is now read-only.

Highlight sticky submissions #16

Merged
merged 5 commits into from
Apr 9, 2019

Conversation

mvietri
Copy link

@mvietri mvietri commented Jan 14, 2019

Following the NSFW design I've added 2 more styles: Sticky and NSFW Sticky as shown below:

sticky_nsfw

Tell me what do you guys think?

@dotvhs
Copy link

dotvhs commented Jan 15, 2019

First one looks really nice! Not sure if those colors are not too bright though? Anyway here's my attempt:
a01 copy 3

If you like them, here are hex values:

BG: #283028
Label: #9CF3AF

On the side note, here's preview of all (also including non-existent SPOILER tag):
a01 copy 3

@mvietri
Copy link
Author

mvietri commented Jan 15, 2019

@dotvhs can you suggest a color for both background and tag for the 'nsfw sticky'? since I'd like to update this branch with those 3 options:

  • Sticky (green)
  • NSFW (red/pink)
  • NSFW & Sticky (???)

@dotvhs
Copy link

dotvhs commented Jan 15, 2019

@dotvhs can you suggest a color for both background and tag for the 'nsfw sticky'? since I'd like to update this branch with those 3 options:

* Sticky (green)

* NSFW (red/pink)

* NSFW & Sticky (???)

I've been thinking about this and I'm not entirely sure. I came up with conclusion that perhaps different color is not needed, because NSFW + Sticky will be seen in 99% cases when whole subreddit is NSFW, so sticky could still be green, just with Sticky NSFW tag (where Sticky label would be green, NSFW pink but background still would be green). Probably for NSFW-only subreddits we don't even need that purple-ish background, only label.

@mvietri
Copy link
Author

mvietri commented Jan 16, 2019

yeah I agree @dotvhs I'll do some changes and post some more images

@mvietri
Copy link
Author

mvietri commented Jan 19, 2019

Final screenshot:

screenshot_1547861998

@mvietri mvietri changed the title [WIP] Sticky submissions Highlight sticky submissions Jan 19, 2019
@Tunous Tunous merged commit b947585 into Tunous:master Apr 9, 2019
@Tunous Tunous added this to the 0.7.0 milestone Aug 10, 2019
@Tunous Tunous added the feature New feature label Aug 10, 2019
@mvietri mvietri deleted the feature/sticky-submission branch August 13, 2019 23:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants