Skip to content
This repository was archived by the owner on Jun 9, 2023. It is now read-only.

Fix title selection after up/downvote #365

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Fix title selection after up/downvote #365

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97ed783
re-limit title selection on title change
AbsurdlySuspicious Jan 22, 2021
5f5e98d
Merge branch 'master' into feature/title-selection-fix
AbsurdlySuspicious Jan 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/src/main/java/me/saket/dank/ui/submission/adapter/SubmissionCommentsHeader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,6 @@ public void render() {
// keeps popping up, so it's probably necessary to set it in code
selfTextView.setTextIsSelectable(true);
selfTextView.setMovementMethod(movementMethod);

// limit selection to title
SubmissionTitleSpan.limitSelectionForTextView(titleView);
}

private void setSubmissionByline(UiModel uiModel) {
Expand All @@ -283,6 +280,9 @@ private void setSubmissionByline(UiModel uiModel) {

private void setSubmissionTitle(UiModel uiModel) {
titleView.setText(uiModel.title());

// limit selection to title
SubmissionTitleSpan.limitSelectionForTextView(titleView);
}

public void renderPartialChanges(List<Object> payloads) {
Expand Down