Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Large image previews #87

Merged
merged 8 commits into from
Jan 12, 2020
Merged

Large image previews #87

merged 8 commits into from
Jan 12, 2020

Conversation

Tunous
Copy link
Owner

@Tunous Tunous commented Oct 14, 2019

Settings Preview

Related to #25

@Tunous Tunous added feature New feature design Changes to the design of the app labels Oct 14, 2019
@Tunous Tunous added this to the 0.8.1 milestone Oct 14, 2019
@tunous-bot
Copy link

Test version of Dank has been automatically built from this pull request.
Click here to download it.

@msfjarvis
Copy link
Collaborator

Been using it for a few days, works perfectly on my Pixel 2 and Samsung M30s 👍

@mvietri
Copy link

mvietri commented Oct 15, 2019

Maybe you could add a bit of padding or margin between submissions? For me at least in some subreddit it's a bit confusing which title is for image since they're all together. Other than that it works fine.

@Tunous
Copy link
Owner Author

Tunous commented Oct 19, 2019

Maybe you could add a bit of padding or margin between submissions?

Done. I've added additional margin above each image:

@tunous-bot
Copy link

Test version of Dank has been automatically built from this pull request.
Click here to download it.

@mvietri
Copy link

mvietri commented Oct 19, 2019

Nicely done!

@saket
Copy link

saket commented Oct 20, 2019

Nice! The gray line separators look redundant in my opinion.

@Tunous Tunous force-pushed the feature/large-image-previews branch from b3e025c to 88a6ef1 Compare January 6, 2020 11:52
@Tunous
Copy link
Owner Author

Tunous commented Jan 6, 2020

I've moved the separators so they don't look so out of place when there is a big image below them.

@tunous-bot
Copy link

Test version of Dank has been automatically built from this pull request.
Click here to download it.

@Tunous Tunous merged commit 5d519d3 into master Jan 12, 2020
@Tunous Tunous deleted the feature/large-image-previews branch January 12, 2020 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design Changes to the design of the app feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants