Add min_time_exceeded flag to the AAT solver results
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah! Thx. |
Turbo87
approved these changes
Jun 22, 2019
|
I just noticed that the test suite is currently failing. Could you fix those failing test assertions so that we can merge the MR? |
kerel-fs
force-pushed
the
pr/aat_min_time
branch
from
ecc2c38 to
8318d5e
Compare
The AAT task solver already respects the AAT min time when calculating the marking speed. Thus we should use the speed result produced by the solver, and not calculate it ourself in the scoring function. Fixes Turbo87#84.
Turbo87
changed the title
min_time_exceeded flag to the AAT solver results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AAT: Show min_time_exceeded flag in the ranking
Example: (display speed
DSpeedand marking speedMSpeedshown separately in this image (this branch only shows the marking speed in the end)Flights which didn't reach the AAT min time are flagged by a star in the time column.
scoring: Use marking speed calculated by the task solver, fixes Live scoring of AAT: AATmin time not taken into account #84