Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd rxFS extension #291

Merged
merged 14 commits into from
Mar 26, 2023
Merged

Readd rxFS extension #291

merged 14 commits into from
Mar 26, 2023

Conversation

0832k12
Copy link
Contributor

@0832k12 0832k12 commented Mar 20, 2023

Readd, no change.

@GarboMuffin
Copy link
Member

GarboMuffin commented Mar 20, 2023

  • please address ESLint errors (see failing checks below)
  • change credit link on homepage to either point to a Scratch profile or no link at all
  • you do not need to close and reopen pull requests. that just causes unnecessary work for both of us.

@GarboMuffin
Copy link
Member

GarboMuffin commented Mar 20, 2023

some other things:

  • extension id should be based on your user folder's name somehow, eg. 0832rxfs
  • if the docsURI page does not have any documentation, the link should be removed

0832k12 added 4 commits March 21, 2023 20:15
new block translations, new storage methods (to prevent import and export failures)
upstream synchronization issues with extended warehouses
@0832k12
Copy link
Contributor Author

0832k12 commented Mar 21, 2023

What should I do with 'All checks have passed'?

@GarboMuffin
Copy link
Member

@GarboMuffin GarboMuffin merged commit 8a6918e into TurboWarp:master Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants