Fix turf-along using raw geometry #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 17, 2016 13:54
…r than line.geometry.coordinates
|
👍 thanks! |
|
Published in turf-along 3.0.4 |
benstoltz
added a commit
to benstoltz/turf
that referenced
this pull request
May 30, 2016
* Remove moot `version` property from bower.json Per bower/spec@a325da3 Also their maintainer says they probably won't ever use it: http://stackoverflow.com/questions/24844901/bowers-bower-json-file-version-property * 📝 fix broken version badge reformat badge markdown for readability * 📝 erase -> difference * Updated package.json to include latest published npm turf-buffer version * link to turfjs-builder app * Remove turf.merge * Add upgrade notes to CHANGELOG * Remove turf_modules dir, merge from README * Unirepo: turf in one repository * Update turf-flip * Bootstrap before test * Port isolines updates * Remove turf-filter and turf-remove * Add multiLineString to helpers. Fixes Turfjs#147 * Add multipoint. Fixes Turfjs#146 * Centralize lint, fix first slew of issues * Finish eslint sweep * Use jscs for better auto-indentation * Merge turf-feature into turf-helpers * Condense turf statistics sprawl into turf-collect * Remove turf-jenks and turf-quantile. Refs Turfjs#306 * Update changelog for removals * Update minified file link The previous link was returning a file not found, repo seems to be gone. I've now linked to the same version being used on https://turfjs-builder.herokuapp.com/ * Update README.md v2.0.2. * Port turf-junkyard/turf-point-on-line#4 * Port improvements from child projects * Add multiPolygon and geometryCollection to helpers * Port turf-junkyard/turf-convex#8 * Add tesselate module * Improve performance by using invariant.getCoord This simplifies calls to methods that previously required GeoJSON: by allowing coordinates as well in those calls, we cut down on churning through objects. This needs a second pass to hook up dependencies and standardize invariant once I land. * Fix tests * Use temp fork of lerna * Bump node * Avoid double-bootstrap * Remove dox, fix bearing dep * Fix typo Turfjs/turf-distance#14 * Update CONTRIBUTING.md * Rename turf-extent to turf-bbox * add inches, yards, metres units to distance function...unsure if configured correctly * Unquote non-quoted object properties https://twitter.com/tmcw/status/723374287537606656. Also update to lerna 2.0.0-beta * add missing semi-colon * Mass simplifications. * move stuff to test * simplify code * remove bad use of 'set' in a bunch of places. we aren't dealing with sets. * ugh the family in front of me doesn't understand timezones and speaks at 80db * Finish turf-combine rethink * Improve line-slice docs. * Document, fix, and test geometry compatibility in turf-line-slice * Fix indentation, clean up triangle grid * Remove tape and benchmark from dependencies * Port turf-junkyard/turf-hex-grid#18 (Turfjs#356) * Port turf-junkyard/turf-hex-grid#18 * Fix eslint * eslint again * Abolish turf-size Refs Turfjs#306 > turf-size rename this turf-resize or something. turf-size is not a good name > 👍 resize is better. I would also be fine with dropping this entirely. I > tend to be using different patterns these days around this type of operation > (explicit distance-based bbox buffers). * Concave use concaveman, fix versions (Turfjs#361) * Concave use concaveman, fix versions * Version * Fix units consistency. Fixes Turfjs#349 (Turfjs#362) * turf-concave tests are BS :( * Port turf-envelope change * Fix npmignore situation, standardize fixture location (Turfjs#363) * Documentation improvements * Documentation improvements * Documentation fixes * Update JSTS * undef * Remove binaries * Remove bins in packages * Fix naive mutations. Fixes Turfjs#116 * Remove turf reclass. Refs Turfjs#306 * Fix indent * No concaveman (Turfjs#369) * Revert concaveman switch * Fix concaveman's fake tests * Make tests real * make grid tests real * Buffer units (Turfjs#371) * Buffer units * Make buffer tests real * Improve docs * Update deps, improve changelog * Downgrade title * Remove lerna from regular deps * Start publishing section of contributing * Fix invariant, fix midpoint * Banner * v3.0.1 * Update CHANGELOG.md * clarify changelog on removals * remove turf-erase in favor of tuf-difference Turfjs#372 (Turfjs#373) * v3.0.2 * Fix turf-collect package name * v3.0.3 * Fix turf-along using raw geometry (Turfjs#376) * coordinate array from raw geometry should pull line.coordinates rather than line.geometry.coordinates * update test suite to test raw geometry checks * v3.0.4 * fix meters factor (Turfjs#377) * v3.0.5 * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am looking at implementing #365 and found that turf-along throws an exception when passing in a raw LineString geometry.
The PR sets the coordinate array as line.coordinates (rather than line.geometry.coordiantes). The PR also updates the test suite to pepper in some raw geometry while testing turf-along.
If there are anything changes I need to make, please let me know.
Thanks!