Replace GLOBAL_RNG with default_rng()
#104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
=======================================
Coverage 97.78% 97.78%
=======================================
Files 7 7
Lines 271 271
=======================================
Hits 265 265
Misses 6 6
Continue to review full report at Codecov.
|
|
Seems CI doesn't like me 😄 The code and the tests seem fine, and the errors are not really reproducible (it's a different test that fails this time, and the downstream test seems to be a bit too strict and would require another tolerance or seed I assume). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Julia >= 1.3, actually
Random.default_rng()is the intended (and now also properly documented: JuliaLang/julia#44733) way to obtain the default RNG.