Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify is_unconstrained docstring #790

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Clarify is_unconstrained docstring #790

merged 1 commit into from
Jan 27, 2025

Conversation

penelopeysm
Copy link
Member

I find the double negatives confusing.

Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.16%. Comparing base (727da63) to head (244ccf2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #790   +/-   ##
=======================================
  Coverage   86.16%   86.16%           
=======================================
  Files          36       36           
  Lines        4301     4301           
=======================================
  Hits         3706     3706           
  Misses        595      595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jan 26, 2025

Pull Request Test Coverage Report for Build 12975008585

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.246%

Totals Coverage Status
Change from base Build 12908348905: 0.0%
Covered Lines: 3706
Relevant Lines: 4297

💛 - Coveralls

@penelopeysm penelopeysm requested a review from mhauru January 27, 2025 11:12
Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@penelopeysm penelopeysm added this pull request to the merge queue Jan 27, 2025
Merged via the queue into master with commit 00e7ee3 Jan 27, 2025
20 checks passed
@penelopeysm penelopeysm deleted the py/doc branch January 27, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants