Feature/histogram #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ucture - Added `d3_histogram_style.css` into the `./static/css/` directory. - Added `d3_histogram.js` under the `./static/js/` directory. - Relocated `data_selection_manager.js` to the `./static/js/` directory.
- Updated setup.cfg to include rcssmin - This addition is necessary for minifying CSS dependency files.
- Implemented `_get_css_dependency_sources()` to gather and optionally minify CSS dependency files. - Implemented `_get_js_dependency_urls()` to gather JS dependency URLs. - Updated `render_html` to include additional parameters for histogram functionality: 1. `histogram_data`: Accepts a list or a Pandas Series to provide data for generating a histogram. If provided, the histogram is rendered; otherwise, it remains disabled. 2. `histogram_settings`: Introduced a dictionary to customize histogram appearance: `histogram_width`, `histogram_height`, `histogram_bin_count`, `histogram_title`, `histogram_bin_fill_color`, `histogram_bin_selected_fill_color`, `histogram_bin_unselected_fill_color`, and `histogram_bin_context_fill_color`.
- Added dynamic inclusion of JS dependency URLs (e.g. d3.min.js) and CSS dependency files (e.g. histogram styles) - Added JS logic to create, select, and dynamically configure the appearance of the histogram.
|
Looks like a great contribution. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added JS and CSS dependency files required for histogram functionality
Introduced
histogram_dataandhistogram_settingsparameters for the template rendering:histogram_dataparameter contains the data used to generate the histogram. Acceptable data types include unsigned integer, signed integer, float, string, and date string in the formatYYYY-MM-DD.histogram_settingsparameter allows customization of the histogram's appearance. Available settings includetitle,width,height,bin count,bin fill color,bin selected fill color,bin unselected fill color, andbin context fill color.E.g. custom appearance:
E.g. integration of the histogram with the scatterplot:
E.g. integration of the histogram with the search field:
