-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(alerting): Add gotify provider #605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small request, but aside from that, excellent work!
alerting/provider/gotify/gotify.go
Outdated
// AppToken is the token of the application to send messages to | ||
AppToken string `yaml:"app-token"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance you could rename this to just token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TwiN ,
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, @bugrakocabay.
* 'master' of https://github.com/TwiN/gatus: (97 commits) docs: add instruction to install as binary (TwiN#615) feat(alerting): make authentication optional for email provider (TwiN#608) feat(alerting): Add gotify provider (TwiN#605) chore(deps): bump github.com/coreos/go-oidc/v3 from 3.6.0 to 3.7.0 (TwiN#604) chore(deps): bump github.com/valyala/fasthttp from 1.49.0 to 1.50.0 (TwiN#594) Feat/modify discord title (TwiN#602) ui: Fix issue back button appearing over title when logo is too small feat(alerting): Add AWS SES Alerting Provider (TwiN#579) chore(deps): bump github.com/wcharczuk/go-chart/v2 from 2.1.0 to 2.1.1 (TwiN#591) ci: Increase timeout-minutes for test workflow to 10 minutes ui: Use localStorage instead of sessionStorage for refresh interval + collapsed groups ui(settings): Fix refresh interval padding chore(deps): bump github.com/prometheus/client_golang from 1.16.0 to 1.17.0 (TwiN#586) chore(deps): bump modernc.org/sqlite from 1.24.0 to 1.26.0 (TwiN#585) fix: Support hexadecimal integers in conditions (TwiN#563) chore(deps): Bump github.com/TwiN/whois to v1.1.7 chore(deps): Bump github.com/TwiN/whois to v1.1.7 fix(alerting): Add support for client.insecure in email alerting provider (TwiN#583) chore(deps): bump github.com/gofiber/fiber/v2 from 2.46.0 to 2.49.2 (TwiN#584) docs: Clean up list of sponsors ...
Hi @TwiN
Summary
Regarding the issue #603, added the support for Gotify provider with tests and documentation.
Checklist
README.md
, if applicable.