-
-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): Add URL to metrics labels #875
Conversation
@TwiN any feedback on this PR? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #875 +/- ##
==========================================
+ Coverage 76.00% 76.01% +0.01%
==========================================
Files 73 73
Lines 6676 6679 +3
==========================================
+ Hits 5074 5077 +3
Misses 1301 1301
Partials 301 301 ☔ View full report in Codecov by Sentry. |
Thank you for the contribution! |
@danlsgiga I don't do this usually, but I had to revert the PR because I don't have the time to fix this right now. After merging, I found out that the URL doesn't discard the query parameters, and that's an issue because unfortunately, many people pass tokens as query parameter (e.g. If you can make another PR that discards all query parameters ( |
Oh, I'm sorry @TwiN, I totally missed this message! I'll look into this and open a new PR! thanks! |
Small feature addition.
Sometimes is useful to have the endpoint URL in metrics labels so we can include that as part of alert messages when these metrics are scraped via prometheus.