fix(walletconnect): use active network chain ID only #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement `activeChainId` getter in `WalletConnect` class to return the CAIP-2 chain ID for the currently active network. Update `connect` and `signTransactions` methods to use this getter. - Add `activeChainId` getter to `WalletConnect` class - Remove `this.chains` property from `WalletConnect` class - Update `connect` method to use `activeChainId` in `requiredNamespaces` - Update `signTransactions` method to use `activeChainId` - Remove optional `chains` parameter from `WalletConnectModal` initialization - Add tests for `activeChainId` getter - Add tests for `activeChainId` usage in `connect` and `signTransactions` - Update existing tests to use `activeChainId` This ensures only the active network's chain ID is included in `requiredNamespaces` for session proposals, fixing issues with wallets that don't support all networks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the
WalletConnectclass by implementing anactiveChainIdgetter to dynamically determine the correct CAIP-2 chain ID based on the active network. TheconnectandsignTransactionsmethods have been updated to use this getter, ensuring that only the chain ID for the currently active network is included in session proposals and transaction signing requests.Details
activeChainIdgetter toWalletConnectclassthis.chainsproperty fromWalletConnectclassconnectmethod to useactiveChainIdinrequiredNamespacessignTransactionsmethod to useactiveChainIdchainsparameter fromWalletConnectModalinitializationactiveChainIdgetter and its usage inconnectandsignTransactionsmethodsactiveChainIdCloses #281