Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tt 5387 update version to v1.3.1 #209

Merged
merged 4 commits into from
May 24, 2022
Merged

Tt 5387 update version to v1.3.1 #209

merged 4 commits into from
May 24, 2022

Conversation

sredxny
Copy link
Contributor

@sredxny sredxny commented May 23, 2022 •
edited
Loading

Description

Updated version.go to be v1.3.1

Related Issue

https://tyktech.atlassian.net/browse/TT-5387

Motivation and Context

Make pre-release

How This Has Been Tested

Ran app

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring or add test (improvements in base code or adds test coverage to functionality)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
    • If new config option added, ensure that it can be set via ENV variable
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • When updating library version must provide reason/explanation for this update.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sredxny sredxny requested a review from tbuchaillot May 23, 2022 19:58
@sredxny sredxny merged commit 08e0e87 into master May 24, 2022
@sredxny sredxny deleted the TT-5387-update-version branch May 24, 2022 21:06
@sredxny
Copy link
Contributor Author

sredxny commented May 24, 2022

/release to release-1.3

@tykbot
Copy link

tykbot bot commented May 24, 2022

Working on it! Note that it can take a few minutes.

tykbot bot pushed a commit that referenced this pull request May 24, 2022
@sredxny
Tt 5387 update version to v1.3.1 (#209)
9f3791a 
* TT-4685 support for comma separated groups claim

* updated version to v1.3.1

(cherry picked from commit 08e0e87)
@tykbot
Copy link

tykbot bot commented May 24, 2022

@sredxny Succesfully merged 08e0e8732a2dff3be402c2ade9baf970e51734e0 to release-1.3 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbuchaillot tbuchaillot tbuchaillot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sredxny @tbuchaillot