Small fixes for lox example #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesMeierSE
approved these changes
Dec 18, 2024
| @@ -28,7 +28,8 @@ | |||
| ], | |||
| "sourceMaps": true, | |||
| "outFiles": [ | |||
| "${workspaceFolder}/examples/lox/out/**/*.js" | |||
| "${workspaceFolder}/examples/lox/out/**/*.js", | |||
| "${workspaceFolder}/examples/lox/node_modules/langium/**/*.js" | |||
There was a problem hiding this comment.
Thanks for this! I was not aware of this
Merged
JohannesMeierSE
added a commit
that referenced
this pull request
Dec 19, 2024
* Renamed "domain element" to "language node", as discussed in #47 * Fixed typos and security vulnerabilities according to #48 (thank you very much @aabounegm!) * Improved the README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating the lox example I recognised these small things. The ox-cli -> lox-cli seems to be a typo to me. The addition to launch.json is inspired by eclipse-langium/langium#410 and parallel to the config of ox.