Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lift assumption that video frame 0 occurs at time 0 #21

Open
CoffeeFlux opened this issue Jan 10, 2019 · 2 comments
Open

Lift assumption that video frame 0 occurs at time 0 #21

CoffeeFlux opened this issue Jan 10, 2019 · 2 comments

Comments

@CoffeeFlux
Copy link
Member

Title.
@moi15moi moi15moi mentioned this issue Sep 13, 2022
Closed
@moi15moi
Copy link
Contributor

If someone need an example to understand this problem, see #169.

@moi15moi moi15moi mentioned this issue Oct 24, 2022
Closed
arch1t3cht added a commit to arch1t3cht/Aegisub that referenced this issue Nov 2, 2024
@arch1t3cht
Stop shifting timecodes to start at 0ms
b7d228c 
This reverts commit 1dedfb1.
Such files exist in the wild (one example being a large set of old CR
rips, see https://redvice.org/2018/crunchyroll-83ms-delay/) and players
like mpv also respect this video delay (at least they do now, they might
not have when the linked commit was made).

Fixes TypesettingTools#21.
Fixes TypesettingTools#169.
odrling pushed a commit to odrling/Aegisub that referenced this issue Dec 19, 2024
@arch1t3cht @odrling
Stop shifting timecodes to start at 0ms
9b5a41e 
This reverts commit 1dedfb1.
Such files exist in the wild (one example being a large set of old CR
rips, see https://redvice.org/2018/crunchyroll-83ms-delay/) and players
like mpv also respect this video delay (at least they do now, they might
not have when the linked commit was made).

Fixes TypesettingTools#21.
Fixes TypesettingTools#169.
@arch1t3cht
Copy link
Member

arch1t3cht#172 is also relevant (and a case where not normalizing timestamps is also problematic).

FFmpeg provides a start_time field in tracks for this which would specify the actual time to shift by (though I have not yet looked into how it is computed), but no source filter currently exposes this. See also the rebase-start-time option in mpv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CoffeeFlux @moi15moi @arch1t3cht