Look for FFmpeg in both user-wide and system-wide PATH locations
#495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyrrrz
reviewed
Aug 31, 2024
Comment on lines
20
to
23
| var UserAndMachineEnvironmentVariables = | ||
| $"{Environment.GetEnvironmentVariable("PATH", EnvironmentVariableTarget.User)}{Environment.GetEnvironmentVariable("PATH", EnvironmentVariableTarget.Machine)}"; | ||
|
|
||
| if (UserAndMachineEnvironmentVariables?.Split(Path.PathSeparator) is { } paths) |
There was a problem hiding this comment.
Please just do two if's/foreach's, it's easier to read this way
There was a problem hiding this comment.
Please just do two
if's/foreach's, it's easier to read this way
Now I did it with two if's/foreach's as you desired.
Please check the next commit.
Tyrrrz
changed the title
PATH locations
Tyrrrz
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Environment.GetEnvironmentVariable("PATH")gives you the effective PATH that the operating system uses when searching for executable files fromUser PATH.Thus if some developers like me add
FFMPEGpath to system PATH they always face with that page which tells there is noFFMPEGinstalled or cannot be found.I had changed codes to get the
PATHfrom both theSystemandUserenvironment variables.