Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed special character regex #47

Merged
merged 3 commits into from
Jan 19, 2024
Merged

fixed special character regex #47

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0015d5d
fixed special character regex
Kierst01 Jan 19, 2024
ba00017
moved TypeError to the top of the function
Kierst01 Jan 19, 2024
5e9717d
moved ValueError
Kierst01 Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/passwordler/password_strength.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,21 @@ def password_strength(password):
Returns:
str: a rating of either 'weak', 'good' or 'strong'
"""
if not isinstance(password, str):
raise TypeError("'password' should be of type 'string'")
elif password == '':
raise ValueError("'password' cannot be an empty string")

count_uppercase = len(re.findall("[A-Z]", password))
count_numbers = len(re.findall('[0-9]', password))
count_special_chars = len(re.findall('[!-\/:-@[-`{-~]', password))
count_special_chars = len(re.findall('[!-/:-@\\[-`{-~]', password))
length = len(password)
common_passwords = ['123456', 'password', '12345', '12345678', 'qwerty', '1234567890', '1234',
'baseball', 'dragon', 'football', '1234567', 'monkey', 'letmein', 'abc123',
'111111', 'mustang', 'access', 'shadow', 'master', 'michael', 'superman',
'696969', '123123', 'batman', 'trustno1']

if not isinstance(password, str):
raise TypeError("'password' should be of type 'string'")
if password == '':
raise ValueError("'password' cannot be an empty string")
elif length >= 12 and count_uppercase >= 1 and count_numbers >= 1 and count_special_chars >= 1 and password not in common_passwords:
if length >= 12 and count_uppercase >= 1 and count_numbers >= 1 and count_special_chars >= 1 and password not in common_passwords:
return 'Your password is: Strong'
elif length >= 8 and (count_uppercase + count_numbers + count_special_chars) >= 2 and password not in common_passwords:
return 'Your password is: Good'
Expand Down