Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added undefined protection to slider javascript #189

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

jmbarne3
Copy link
Contributor

Description
A bit of data that is supposed to be added to the month and year links is not being added when the page is rendered. I have not been able to track down why the data attribute is not being added, but the process is supposed to fail gracefully and currently is not. I've added logic that allows the fallback logic - of linking to that calendar month or year view, respectively - to run if the data-ajax-link isn't defined.

Motivation and Context
This will correct the bug reported by Roger in the events channel.

How Has This Been Tested?
Changes are in dev and qa.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires an update to the documentation.
  • I have updated the documentation accordingly.

@jmbarne3 jmbarne3 added the Bug label Jun 19, 2024
@jmbarne3 jmbarne3 self-assigned this Jun 19, 2024
@jmbarne3 jmbarne3 requested a review from a team as a code owner June 19, 2024 17:07
@jmbarne3 jmbarne3 requested review from kimberspencer and Ramin-Farhadi and removed request for a team June 19, 2024 17:07
@jmbarne3 jmbarne3 merged commit 177184f into master Jun 19, 2024
@jmbarne3 jmbarne3 deleted the hf-calendar-click branch June 19, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants