Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for get_axial_length for cylindrical scanners. #1495

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

robbietuk
Copy link
Collaborator

Changes in this pull request

Adds support for cylindrical scanners to call get_axial_length() and return a sensible value.

I believe

get_num_rings() * get_ring_spacing();

is the correct implementation over

get_ring_spacing() * (get_num_rings() - 1);

because a scanner with 1 ring will have an axial length of that ring. That is, unless axial bin size should be incorporated into the calculation.

Related issues

Fixes #1493

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added docstrings/doxygen in line with the guidance in the developer guide
  • [] I have implemented unit tests that cover any new or modified functionality (if applicable)
  • The code builds and runs on my machine
  • [] documentation/release_XXX.md has been updated with any functionality change (if applicable)

@robbietuk robbietuk added the bug label Aug 23, 2024
@KrisThielemans KrisThielemans self-assigned this Aug 24, 2024
@KrisThielemans KrisThielemans added this to the v6.3 milestone Aug 24, 2024
@KrisThielemans KrisThielemans merged commit c51067d into UCL:master Aug 25, 2024
8 checks passed
@robbietuk robbietuk deleted the get_axial_length_for_cylindrical branch August 29, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scanner get_axial_length() gives negative values with Cylindrical geometries
2 participants