Add support for get_axial_length for cylindrical scanners. #1495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Adds support for cylindrical scanners to call
get_axial_length()
and return a sensible value.I believe
is the correct implementation over
because a scanner with 1 ring will have an axial length of that ring. That is, unless axial bin size should be incorporated into the calculation.
Related issues
Fixes #1493
Checklist before requesting a review
documentation/release_XXX.md
has been updated with any functionality change (if applicable)