38 allow pdf as a valid readme format

e4e_data_management/core.py

@@ -282,6 +282,20 @@ def push(self, path: Path) -> None:
         """
         self.active_dataset.check_complete()
 
+        # Check that the README is present
+        readmes = [file
+                   for file in list(self.active_dataset.root.glob('*'))
+                   if re.match(fnmatch.translate('readme.*'), file.name, re.IGNORECASE)]
+
+        if len(readmes) == 0:
+            raise RuntimeError('Readme not found')
+        acceptable_exts = ['.md', '.docx', '.pdf']
+        if not any(readme.suffix.lower() in acceptable_exts for readme in readmes):
+            raise RuntimeError('Illegal README format')
+
+        # validate self
+        self.active_dataset.validate()
+
         # Duplicate to destination
         destination = path.joinpath(self.active_dataset.name)
         destination.mkdir(parents=True, exist_ok=False)

tests/test_push.py

@@ -38,7 +38,8 @@ def test_push(single_mission_data: Tuple[Tuple[Mock, DataManager, Path], Tuple[P
     'README.MD',
     'readme.docx',
     'readme.DOCX',
-    'Readme.docx'
+    'Readme.docx',
+    'readme.pdf'
 ])
 def test_valid_readme_names(single_mission: Tuple[Mock, DataManager, Path], readme_name: str):
     """Tests valid readme names