Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto data storage #1

Closed
wants to merge 25 commits into from
Closed

Auto data storage #1

wants to merge 25 commits into from

Conversation

charlesrt
Copy link

@charlesrt charlesrt commented Feb 17, 2017

This is alphagov#340 which hasn't been merged into the main kit yet. There is an outstanding issue with checkboxes but you can work around that separate tags for each checkbox rather than one for the whole fieldset.

joelanman and others added 25 commits January 13, 2017 17:56
To match the change made to GOV.UK elements: alphagov/govuk_elements#389
Remove the title attribute from the cookie message
Removing links to route.js / updating example in branching.html
This solves the problem with prototypes asking for username/password
twice.

The problem is caused by the ordering in the middleware.

When a user types in the URL for a prototype like
http://govuk-tagging.herokuapp.com they're asked for a
username/password first (via `utils.basicAuth`).

After filling that in they'll be able to "proceed" to the next step,
which redirects them to the `https://` version (via
`utils.forceHttps`).

Because the auth isn't shared between `http` and `https` version, they
are not authenticated anymore and have to enter their username/password
again.

Validated with https://test-prevent-double-auth.herokuapp.com/
Prevent asking users to authenticate twice
Add ability to override service name on a page
…n-promo-mode

Allow search indexing in promo mode
bump gulp-sass to increase node-sass dependency
@charlesrt charlesrt closed this Feb 17, 2017
@charlesrt
Copy link
Author

charlesrt commented Feb 17, 2017

Closed as picked the branches the wrong way round and Github doesn't let you edit the target branch.
See #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants