Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach has some issues when downloading repos from the Hub. The current approach skips downloading if a local directory is already present. This means that local files can easily get outdated if there are changes in the repo in the Hub. Users only get the latest model if they delete the directory from the cache. Additionally, if one file is missing (such as
modules.json
, it doesn't get automatically downloaded).With this new approach, we always call
snapshot_download
and directly save in the expected directory instead of renaming the directory afterwards. It has this behavior:This ensures that the local files are updated but maintaining the benefits of client-side caching.