Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transformers requirement in setup.py to match requirements.txt #2589

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

maxfriedrich
Copy link
Contributor

Hi, #2574 was not enough to set a new minimum transformers version, pip will still install version 4.32.0 even though it's not compatible.

e.g.

> pip install transformers==4.31.0 git+https://github.com/UKPLab/sentence-transformers.git
ERROR: Cannot install sentence-transformers==2.7.0.dev0 and transformers==4.31.0 because these
package versions have conflicting dependencies.

> pip install transformers==4.32.0 git+https://github.com/UKPLab/sentence-transformers.git
(works fine)

@maxfriedrich
Copy link
Contributor Author

FYI, I also opened a PR on the conda-forge feedstock to update dependencies conda-forge/sentence-transformers-feedstock#37

@tomaarsen
Copy link
Collaborator

Hello!

Thanks for catching this; I forgot that Sentence Transformers still stores the versions in two places.

  • Tom Aarsen

@tomaarsen tomaarsen merged commit 57ea98c into UKPLab:master Apr 16, 2024
9 checks passed
@tomaarsen
Copy link
Collaborator

Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants