feat: add trust remote code to cross encoders #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaarsen
reviewed
Apr 16, 2024
| :param trust_remote_code: Whether or not to allow for custom models defined on the Hub in their own modeling files. | ||
| This option should only be set to True for repositories you trust and in which you have read the code, as it | ||
| will execute code present on the Hub on your local machine. | ||
| :param revision: The specific model version to use. It can be a branch name, a tag name, or a commit id, |
tomaarsen
reviewed
Apr 16, 2024
|
@tomaarsen my colleague did some test let me try again :) |
|
you're right, i tested again, even through the results are identical, without adding tensor([0.2811, 0.3452, 0.8731])
The repository for jinaai/jina-reranker-v1-tiny-en contains custom code which must be executed to correctly load the model. You can inspect the repository content at https://hf.co/jinaai/jina-reranker-v1-tiny-en.
You can avoid this prompt in future by passing the argument `trust_remote_code=True`.
Do you wish to run the custom code? [y/N] y
[0.28105804 0.34524447 0.87314653]after adding it: tensor([0.2811, 0.3452, 0.8731])
[0.28105804 0.34524447 0.87314653]I updated the PR :) thanks! Bo |
|
Thanks a bunch for this PR! It should be ready. I'll get this released tomorrow or Thursday as v2.7.0.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny PR to allow
trust_remote_codeinCrossEncoderto align withSentenceTransformersignature.Also a bit cleaning of the code, remove duplicate variables and re-order the docstring.