[training] Pass steps/epoch/output_path to Evaluator during training
#3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both in fit_mixin and the trainer Plus fixing 2 evaluators
|
Thank you very much @tomaarsen for the quick response 👍🏾 |
|
Gladly! You can use this already with: And otherwise this will be included in the next release.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3062
Hello!
Pull Request overview
steps/epoch/output_pathto Evaluator during trainingmodel.fit()and theSentenceTransformerTrainerDetails
The
model.fitnorSentenceTransformerTrainerpassed all available parameters down to the evaluator(s). In particular, theoutput_pathwasn't sent, which meant that no csv files could be written for the evaluators. Beyond that, 2 evaluators failed when writing to disk. Some better tests for the evaluators would be appreciated, as this could've been caught.