Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.2.0 #38

Merged
merged 41 commits into from
Mar 26, 2021
Merged

v3.2.0 #38

merged 41 commits into from
Mar 26, 2021

Conversation

rernst
Copy link
Member

@rernst rernst commented Mar 5, 2021

Features

Bugs

ExonCov/cli.py Show resolved Hide resolved
@FiniDG
Copy link

FiniDG commented Mar 11, 2021

you have a new panel that you call "panel_new"
PanelNewVersionForm, panel_new_version
but also the file_names of these panels -->
ExonCov/templates/panel_update.html → ExonCov/templates/panel_new_version.html
ExonCov/templates/panel_update_confirm.html → .../templates/panel_new_version_confirm.html

what if the panel will be updated again? isn't it still just an update panel? or do you still use the "old" version somewhere in the code?

Copy link

@FiniDG FiniDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit
I cannot really tell what this code does. solves #22 but there is not much information to be found there.
Add 100 random samples sampleset to CLI
I guess the code here selects 100 samples, except for "special" projects and based on a date-range?

ExonCov/forms.py Outdated Show resolved Hide resolved
ExonCov/forms.py Outdated Show resolved Hide resolved
ExonCov/cli.py Show resolved Hide resolved
ExonCov/__init__.py Outdated Show resolved Hide resolved
@rernst
Copy link
Member Author

rernst commented Mar 11, 2021

you have a new panel that you call "panel_new"
PanelNewVersionForm, panel_new_version
but also the file_names of these panels -->
ExonCov/templates/panel_update.html → ExonCov/templates/panel_new_version.html
ExonCov/templates/panel_update_confirm.html → .../templates/panel_new_version_confirm.html

what if the panel will be updated again? isn't it still just an update panel? or do you still use the "old" version somewhere in the code?

So each panel can have multiple versions. For example, https://exoncov-test.op.umcutrecht.nl/panel/AMY01:
Panel = AMY01, Versions: AMY01v21.1 and AMY01v19.1.

'Panel_new' = creating a new Panel + first version.
'Panel_new_version' = create a new version.

It is posible to use panel_update multiple times, creating multiple versions.

@rernst rernst requested a review from FiniDG March 12, 2021 09:38
Copy link

@FiniDG FiniDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answered all questions clearly and fixed some small issues. Therefore approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants