Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/non zero exitcode rsync #75

Merged
merged 11 commits into from
Feb 29, 2024
Merged

Conversation

ellendejong
Copy link
Contributor

@ellendejong ellendejong commented Feb 29, 2024

What has changed?

If rsync command failed, exitcode would stay 0.
Changed the implementation to check on returncode. Therefore replaced os.system with subprocess_run.

The non-zero returncode of rsync should result in a non-zero returncode of the script, by using sys.exit(). Moved the compress, index and rsync for exon measurements after the transcript measurements, so that these are still added to ExonCov.

Additional information

This is a bugfix. Therefore several items are ignored:

  • Script doesnot pass flake8 and our coding style guides.
  • Docstrings and unit tests not added.

@ellendejong ellendejong merged commit 326aa0f into develop Feb 29, 2024
@rernst rernst deleted the fix/non_zero_exitcode_rsync branch March 8, 2024 15:42
@rernst rernst mentioned this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants