Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/rocky8 python3 #76

Merged
merged 9 commits into from
Apr 12, 2024
Merged

Feature/rocky8 python3 #76

merged 9 commits into from
Apr 12, 2024

Conversation

rernst
Copy link
Member

@rernst rernst commented Mar 19, 2024 •
edited
Loading

  • Upgrade Flask to Flask==2.2.5 (not 2.3.x because of dependencies incompatibility).
  • Add Gunicorn WSGI server
  • Use flask.cli for cli
  • Switch to flask-security fork -> flask-Security-Too
    • Add fs_uniquifier column to user model.
  • Fix joinedload calls
  • Add extra_validators=[] to validate form calls.

ellendejong
ellendejong requested changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@ellendejong ellendejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flask.cli improves readability, amazing :)

I added check-boxes to items which I would like to see addressed.

ExonCov/cli.py Outdated Show resolved Hide resolved
ExonCov/cli.py Outdated Show resolved Hide resolved
ExonCov/cli.py Outdated Show resolved Hide resolved
ExonCov/cli.py Outdated Show resolved Hide resolved
ExonCov/cli.py Show resolved Hide resolved
ExonCov/cli.py Outdated Show resolved Hide resolved
ExonCov/views.py Show resolved Hide resolved
@rernst rernst requested a review from ellendejong March 25, 2024 14:59
@rernst rernst merged commit be3040d into develop Apr 12, 2024
@rernst rernst deleted the feature/rocky8_python3 branch April 12, 2024 14:17
@rernst rernst mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellendejong ellendejong ellendejong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rernst @ellendejong