New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/upgrade nextflow #74

Merged

rernst merged 7 commits into develop from feature/upgrade_nextflow

Aug 8, 2023

Member

rernst commented Jul 31, 2023

Support for nextflow v23.04.2
- Changes are backward compatible, tested with (20.04.1.5335)

rernst added 5 commits

July 28, 2023 14:25


          Add val() to value inputs and outputs

46cc332


          Add val() to value inputs and outputs

f233e75


          Add val() to value inputs and outputs


          Merge branch 'feature/upgrade_nextflow' of github.com:UMCUGenetics/Ne…

b51f699

…xtflowModules into feature/upgrade_nextflow


          Add val() to value inputs and outputs

c34fea5

lvanoijen reviewed

View reviewed changes

BCFtools/1.10.2/View.nf Outdated Show resolved Hide resolved

lvanoijen reviewed

View reviewed changes

BCFtools/1.10.2/View.nf Outdated Show resolved Hide resolved

lvanoijen reviewed

View reviewed changes

BamUtil/1.0.14/ClipOverlap.nf Outdated Show resolved Hide resolved

lvanoijen reviewed

View reviewed changes

BamUtil/1.0.14/ClipOverlap.nf Outdated Show resolved Hide resolved

lvanoijen reviewed

View reviewed changes

FastQC/0.11.5/FastQC.nf Outdated Show resolved Hide resolved

lvanoijen reviewed

View reviewed changes

Manta/1.6.0/Manta.nf Outdated Show resolved Hide resolved

lvanoijen requested changes

View reviewed changes

lvanoijen left a comment

Almost ok. There are some closing brackets missing. And looking at the files that aren't changed there is 1 val() change missed in the input of file GATK/4.1.3.0/SplitIntervals.nf.

rernst added 2 commits

August 8, 2023 16:36


          Add missing brackets and fix review comments

b9cc20a


          Merge branch 'develop' into feature/upgrade_nextflow

841c1db

rernst requested a review from lvanoijen

August 8, 2023 14:39

Member Author

rernst commented Aug 8, 2023

Almost ok. There are some closing brackets missing. And looking at the files that aren't changed there is 1 val() change missed in the input of file GATK/4.1.3.0/SplitIntervals.nf.

Thanks, fixed the missing brackets and val() change. Also merged develop to fix merge conflict.

lvanoijen approved these changes

View reviewed changes

rernst merged commit 16b537a into develop

rernst deleted the feature/upgrade_nextflow branch

August 8, 2023 14:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet