Long due nextflowmodules update #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/v0.7.1
Release/v0.7.2
rernst
requested changes
Aug 22, 2023
There was a problem hiding this comment.
Nice work @ffmmulder
Some more general comments:
- Double check all
valinput/outputs. - Remove old sge configs
- Check code style, especially for long lines. Also try not to combine short and long arguments in one process, for example
-ivs--input. - Double check choice between
tuple(input1, input2)input and using multiple input channels. Did you make a choice on purpose?
input 1
input 2
BCFtools/1.17/MergeVCF.nf
Outdated
| shell = ['/bin/bash', '-euo', 'pipefail'] | ||
|
|
||
| input: | ||
| tuple sample_id, file(bcf_file) |
There was a problem hiding this comment.
Make sure to add val: tuple(val(sample_id), file(bcf_file)).
BCFtools/1.17/View.nf
Outdated
Comment on lines
9
to
10
| input: | ||
| tuple sample_id, file(bcf_file) |
There was a problem hiding this comment.
If you add an 'output extension' input/parameter you could in theory also use the same function to convert vcf to bcf.
| shell = ['/bin/bash', '-euo', 'pipefail'] | ||
|
|
||
| input: | ||
| tuple(val(sample_id), val(rg_id), path(fastq)) |
| tag {"BWA_MEM2 BWASW ${sample_id} - ${rg_id}"} | ||
| label 'BWA_MEM2_2_2_1' | ||
| label 'BWA_MEM2_2_2_1_BWASW' | ||
| container = 'blcdsdockerregistry/bwa-mem2_samtools-1.12:2.2.1' |
There was a problem hiding this comment.
Why do you need an container with samtools? Maybe just use bwa biocontainer?
| tag {"BWA_MEM2 Index $fasta"} | ||
| label 'BWA_MEM2_2_2_1' | ||
| label 'BWA_MEM2_2_2_1_Index' | ||
| container = 'library://blcdsdockerregistry/bwa-mem2_samtools-1.12:2.2.1' |
GATK/4.3.0.0/GenotypeGVCFs.nf
Outdated
| tuple(val(run_id), val(interval), path(gvcf), path(gvcftbi), path(interval_file)) | ||
|
|
||
| output: | ||
| tuple(val(run_id), val(interval), path("${run_id}.${interval}.${ext_vcf}"),path("${run_id}.${interval}.${ext_index}"),path(interval_file), emit : genotyped_vcfs) |
GATK/4.3.0.0/HaplotypeCaller.nf
Outdated
| tuple(val(sample_id), path(bam), path(bai), path(interval_file)) | ||
|
|
||
| output: | ||
| tuple(val(sample_id), val(int_tag) ,path("${sample_id}.${int_tag}.${ext_vcf}"), path("${sample_id}.${int_tag}.${ext_index}"), path(interval_file), emit: htcaller_vcfs) |
| tuple(val(sample_id), path(bam_file), path(bai_file)) | ||
|
|
||
| output: | ||
| tuple (val(sample_id), val(sample_id), path("${sample_id}.RG.bam"), path("${sample_id}.RG.bai"), emit: readgroup_bams) |
| tuple(val(sample_id), path(bam_file), path(bai_file)) | ||
|
|
||
| output: | ||
| tuple(val(sample_id), val(sample_id), path("${sample_id}.RG.bam"), path("${sample_id}.RG.bai"), emit: readgroup_bams) |
Sambamba/0.8.2/MergeBams.nf
Outdated
| tag {"Sambamba MergeBams ${sample_id}"} | ||
| label 'Sambamba_0_8_2' | ||
| label 'Sambamba_0_8_2_MergeBams' | ||
| clusterOptions = workflow.profile == "sge" ? "-l h_vmem=${params.mem}" : "" |
|
@ffmmulder What is the status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some new tools/modules (such as AGAT, Deeplexicon,edgeR,DESeq2)
Updated module versions for all tools (to be used in v2 of NF-IAP/RNAseq pipelines)
Updated GATK tmpdir usage where not updated yet
Fixed/improved formatting where not updated yet
Other small (bug)fixes