Feature/nextflow upgrade 23 10 0 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release/v0.7.1
Release/v0.7.2
ellendejong
reviewed
Jan 10, 2024
There was a problem hiding this comment.
Wow, amazing effort to add the val() qualifier everywhere, I approve these changes.
Some changed I would like to see:
- Long input or output tuples/lines (aka >127 characters)
- Inconsistency in whitespaces
I do see some inconsistencies in use of whitespaces. Sometimes a whitespace is added:
tuple (.....) vs tuple(...)
And there are some whitespaces before the closing brackets:
tuple(emit: fake) vs tuple ( emit: fake )
and whitespaces after a comma:
val(a),val(b), val(c) vs val(a), val(b), val(c) vs val(a),val(b),val(c)
Could you fix these inconsistencies as well to tuple(val(a), val(b), emit: fake)?
Did you check whether deprecated functions/operators are used anywhere?
https://www.nextflow.io/docs/latest/dsl1.html#channels
https://www.nextflow.io/docs/latest/dsl1.html#operators
This reverts commit 1d4f005.
ellendejong
previously approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of the in- and output variables so that the workflows can be run with Nextflow 23.10.0