Created documentation on how to jumpbox w/ ansible documention + copi… #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed over some files from the prev 2024 ccdc repo
DaintyJet
requested changes
Oct 24, 2024
| @@ -0,0 +1,3 @@ | |||
| sudo apt-add-repository ppa:ansible/ansible | |||
There was a problem hiding this comment.
With these kind of scripts I prefer if they have a EUID check for sudo and exit early rather than including sudo xyz this is just my preference.
Comment on lines
+38
to
+42
| - name: Copy SSH public key | ||
| authorized_key: | ||
| user: "alex" | ||
| key: "{{ lookup('file', '~/.ssh/id_ed25519.pub') }}" | ||
| state: present |
There was a problem hiding this comment.
Maybe make this more generic @P-rple I know Alex wrote it but you copied it over : )
Comment on lines
+44
to
+48
| - name: Remove all lines from sshd_config | ||
| lineinfile: | ||
| path: /etc/ssh/sshd_config | ||
| state: absent | ||
| regexp: '.*' |
There was a problem hiding this comment.
I think this is a bit dangerous for our use case...
There was a problem hiding this comment.
Good for clean starts but still dangerous
Comment on lines
+13
to
+18
| tasks: | ||
| - name: Copy SSH public key | ||
| authorized_key: | ||
| user: "alex" | ||
| key: "{{ lookup('file', '~/.ssh/id_ed25519.pub') }}" | ||
| state: present |
There was a problem hiding this comment.
Same thing of making this more generic, probably read from a file and copy all contents over?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed over some files from the prev 2024 ccdc repo
Overview of Changes
General overview of what has been changed
Reason for Modification
This section will list the reasons modifications were performed. This justifies why the changes are necessary or the documentation should be added.
Verification
Images.