Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bandaid::getEmployees #117

Merged
merged 3 commits into from
Mar 13, 2024
Merged

fix: Bandaid::getEmployees #117

merged 3 commits into from
Mar 13, 2024

Conversation

jxjj
Copy link
Contributor

@jxjj jxjj commented Mar 13, 2024

  • change how we're getting dept employees to fix issue where some courses aren't appearing if the instructor isn't technically part of the department
  • remove wrapping post request with form_params.
  • use names table for fallback if LDAP getting fails, and do a best attempt to create user

jxjj added 3 commits March 13, 2024 16:05
@jxjj
fix: Bandaid::getEmployees
1f8d23f 
remove wrapping post request with `form_params`. Bandaid api expects plain `{"emplids": [array]}`.
@jxjj
add getNames method to bandaid
ab00cc5
@jxjj
fallback to use names if not in LDAP
9f206eb
@jxjj jxjj requested a review from cmcfadden March 13, 2024 21:16
@jxjj jxjj self-assigned this Mar 13, 2024
@cmcfadden cmcfadden merged commit b5f29ac into develop Mar 13, 2024
2 checks passed
@jxjj jxjj deleted the feature/missing-cla-8000 branch March 13, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmcfadden cmcfadden cmcfadden approved these changes

Assignees

@jxjj jxjj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxjj @cmcfadden