fix: null returned from getTerms() #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous PR, we changed the allow_redirects option to false to fix a failing CI test. ``` Http::globalOptions([ 'allow_redirects' => false, ]); ``` The side effect was that `Bandaid::getTerms()` would fail because it relied on a redirect. It's url `/classes/terms/` contained a trailing slashes, which previously would be redirected to `/classes/terms` (no trailing slash). This removes the trailing slash to resolve the issue.
cmcfadden
approved these changes
Aug 26, 2024
jxjj
deleted the
feature/fix-null-results-returned-from-bandaid-get-terms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous PR, we changed the allow_redirects option to false in the Bandaid service to fix a failing CI test:
The side effect was that
Bandaid::getTerms()would fail because it relied on a redirect. It's url/classes/terms/contained a trailing slashes, which previously would be redirected to/classes/terms(no trailing slash).This removes the trailing slash to resolve the issue.