Fix regression: some leaves do not appear in leave report (stacked on #193) #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves an issue where some leaves would not appear in the dept leave report if they're leave start/end dates were in the liminal space between terms (like the term payroll leave dates). Accidentally swapped the dates after #191, and then "fixed" the broken test by casting strings to Carbon object.
cmcfadden
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an regression after #191 where some leaves would not appear in the dept leave report if they're leave start/end dates were in the liminal space between terms (like the term payroll leave dates).
Accidentally swapped the dates after #191, and then "fixed" the broken test by casting strings to Carbon object.