fix: instructors with leave not appearing in leave report #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on't show up removes the check to only show people with visible sections. Fixes #203
cmcfadden
approved these changes
Sep 13, 2024
jxjj
deleted the
feature/203-Leave-planning-report---users-who-have-leaves-in-date-range-should-appear-in-report
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the leave report filter logic to show instructors who have leaves, but may not have any taught sections that are visible (because of say, term filters).
removes the check to only show people with visible sections.
Resolves #203
On dev (tho the screenshot is from local)