Add scheduling report courses view #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teaching-history-by-courses-and-term
When getting courses by terms, it's possible for there to be more than one course record in the set since there could be more than 1 TA or primary instructor (or both). This changes things so that a `course` contains an `instructors` list which has all the course instructors. Now, each course within a term should be unique, and all the course's instructors or ta's will be on the single record. This should make it easier to pivot from listing records by instructors or ta's to by courses.
copilot always wants to autocomplete this way, so might as well go with the flow
functionality
to InstructorDetails.vue
mostly this is for me to double check that I'm not duplicating data
Tests are failing when we initialize the `termsStore` in `App.vue`. Because Bandaid server data isn't available, a 500 error will show up in the console, which causes Cypress to fail. Instead of initializing the `termStore` in `App`, this commit refactors to initialize only when `useTermsStore` is invoked. Mocking the termsStore was another option, but we're currently not testing anything in bluesheet that relies in bandaid.
jxjj
deleted the
feature/71-Scheduling-report-add-view-of-teaching-history-by-courses-and-term
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the scheduling report to include a Courses view of a group's class history, and changes Instructor and Teaching Assistant views to tabs.
Instructor leaves for each semester are listed in the first row. Each row shows course history. Each cell contains instructors who taught the course. Courses are considered equivalent from term to term if their department and catalog number's are the same (ARTH-1001).
useTermsanduseGroupCourseHistory.piniafor state management.vuexis still used for current user state, and will be migrated to pinia eventually.