Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search input shows native "x" to clear input #246

Closed
jxjj opened this issue Oct 4, 2023 · 0 comments · Fixed by #270
Closed

Search input shows native "x" to clear input #246

jxjj opened this issue Oct 4, 2023 · 0 comments · Fixed by #270

Comments

@jxjj
Copy link
Contributor

jxjj commented Oct 4, 2023

Search input shows native "x" to clear input.

This happened after switching the input type to search. With a search input, browsers will render a native clear search x. But, we already have a custom clear search button. Either remove the native clear search or customize it match our the original clear search. (I think the x is rendered in the ShadowDOM, but I'm not sure if all browser vendors allow customization).

An alternative is switching back to a text input.

jxjj added a commit that referenced this issue May 2, 2024
resolved Search input shows native "x" to clear input #246
@jxjj jxjj closed this as completed in #270 May 14, 2024
jxjj added a commit that referenced this issue May 14, 2024
resolved Search input shows native "x" to clear input #246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant