Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update datatables to v2 #197

Merged
merged 5 commits into from
Dec 21, 2024
Merged

update datatables to v2 #197

merged 5 commits into from
Dec 21, 2024

Conversation

jxjj
Copy link
Contributor

@jxjj jxjj commented Dec 20, 2024

  • This update datatables package to v2 for vue components (on the admin side).
  • The non-admin side is still using datatables v1, which is directly copied into app/assets.
  • CSS classes changed a bit between v1 and v2. v2 namespaces everything under .dt-* so I don't think there should be conflicts with non-admin stuff, but keep an eye out for style quirks on the admin side.

on dev for testing

@jxjj jxjj requested a review from cmcfadden December 20, 2024 22:36
@jxjj jxjj self-assigned this Dec 20, 2024
@jxjj jxjj merged commit 5ab1424 into develop Dec 21, 2024
2 checks passed
@jxjj jxjj deleted the feature/update-datatables-pre-8.0 branch December 21, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmcfadden cmcfadden cmcfadden approved these changes

Assignees

@jxjj jxjj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxjj @cmcfadden