Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update example markup for fonts in README #469

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

rupl
Copy link
Contributor

@rupl rupl commented Feb 23, 2024

Refs: CD-514, 25775b7, #448

Types of changes

  • ✔️ Improvement (non-breaking change which iterates on an existing feature)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Security update (dependency updates, or to fix a vulnerability)

Description

Changes the README to show our recommended HTML for font-loading in case someone implements CD outside Drupal.

Steps to reproduce the problem or Steps to test

  1. Just check the README and compare to a Drupal install.

Impact

README only. No change to any implementation.

PR Checklist

  • I have followed the Conventional Commits guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@rupl rupl requested a review from left23 February 23, 2024 14:07
@rupl rupl merged commit 94dca2c into develop Feb 26, 2024
1 check passed
@rupl rupl deleted the CD-514-docs branch February 26, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants