Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): OCHA Services separator should inherit color #479

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

rupl
Copy link
Contributor

@rupl rupl commented Apr 30, 2024

In case the footer color is so light that a different text color is needed, this rule will mean the separator always matches text color.

Refs: CD-547

Types of changes

  • ✔️ Improvement (non-breaking change which iterates on an existing feature)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Security update (dependency updates, or to fix a vulnerability)

Description

We had a "hardcoded" CSS Var for OCHA Services separator, but now it uses currentColor to make it more override-friendly.

Impact

CSS only. No impact.

PR Checklist

  • I have followed the Conventional Commits guidelines.

In case the footer color is so light that a different
text color is needed, this rule will mean the separator
always matches text color.

Refs: CD-547
@rupl rupl merged commit 8c7b648 into develop Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant