Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: style status messages for 10.3 #489

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

lazysoundsystem
Copy link
Contributor

Refs: OPS-10532

Types of changes

  • Improvement (non-breaking change which iterates on an existing feature)
  • ✔️ Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Security update (dependency updates, or to fix a vulnerability)

Description

Discovered during testing feedback from GMS - a change in bigpipe means now theme-hints for status messages don't work as they did. As suggested in https://www.drupal.org/project/drupal/issues/3456176, we now should theme them in a js template rather than through twig. Leaving the twig template for status messages that aren't handled by js.

Steps to reproduce the problem or Steps to test

  1. Trigger a status message on a non-admin page.

Impact

How does the proposed change impact existing implementations? What action is needed to accommodate these changes?

PR Checklist

  • I have followed the Conventional Commits guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have made changes to the sub theme to reflect those in the base theme

@lazysoundsystem lazysoundsystem requested a review from attiks August 7, 2024 12:53
@lazysoundsystem lazysoundsystem merged commit fadb1e3 into develop Aug 8, 2024
1 check passed
@lazysoundsystem lazysoundsystem deleted the OPS-10532-status-messages branch August 8, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants