chore: avoid lazy loading for print

[lazysoundsystem]

Refs: OPS-11125

Types of changes

• ✔️ Improvement (non-breaking change which iterates on an existing feature)

Description

Remove lazy loading before printing.

Steps to reproduce the problem or Steps to test

https://humanitarian.atlassian.net/browse/OPS-11125

Impact

This adds a snippet of js to all pages, to avoid printing lazy-loading images. This may be too much.

PR Checklist

• [ x ] I have followed the Conventional Commits guidelines.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have made changes to the sub theme to reflect those in the base theme

[orakili]

$ assumes that jquery is globally available. Iframe also can be lazy loaded.

So better be more generic and use vanilla JS:

Suggested change

	$('img').each(() => {
	$(this).removeAttr('loading');
	document.querySelectorAll('[loading="lazy"]').forEach(element => {
	element.removeAttribute('loading');
	});

Notes

This may not be enough to force load the images and iframes, depending on the browsers. This needs testing and if that doesn't work, re-setting the src attribute for example may do the trick.

This may also require adjusting the waiting time on the snap tool.

[lazysoundsystem]

Thanks, I've made the changes and a feature branch for RWR with this as a patch so I can test it there.

[lazysoundsystem]

The patch is now on the feature instance, where it seems to be working as intended: https://stage.response-reliefweb-int.ahconu.org/fr/central-african-republic/bulletin-humanitaire/reponse-durgence

[orakili]

Suggested change

	element.removeAttr('loading');
	element.removeAttribute('loading');

removeAttr is jQuery, please use removeAttribute.

[lazysoundsystem]

ouch. sorry.

[orakili]

The code looks ok but not sure if that fixes the problems. As mentioned in the ticket, what was tested might not have been a good example.

I would be hesitant to add another piece of javascript to all the sites using the common design without ensuring that it actually does something useful.

[lazysoundsystem]

Agreed, adding 'blocked' label until I can prove this helps.