Merge pull request #204 from UN-OCHA/HPC-10000

HPC-10000: Remove `null` from `planEntityIds` codec
UN-OCHA · Jan 23, 2025 · 829a54f · 829a54f
2 parents 543ff9e + 26ad1f2
commit 829a54f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@unocha/hpc-api-core",
-  "version": "10.8.0",
+  "version": "10.8.1",
   "description": "Core libraries supporting HPC.Tools API Backend",
   "license": "Apache-2.0",
   "private": false,

diff --git a/src/db/models/planEntityVersion.ts b/src/db/models/planEntityVersion.ts
@@ -19,13 +19,7 @@ export const PLAN_ENTITY_VERSION_ID = brandedType<number, PlanEntityVersionId>(
 );
 
 const PLAN_ENTITY_VERSION_REF = t.partial({
-  /**
-   * TODO: Some values in the database seem to have null values in this
-   * array, which is problematic. We need to have stricter validation of
-   * data being stored here, repair existing values, and then remove null
-   * from this type
-   */
-  planEntityIds: t.array(t.union([t.null, PLAN_ENTITY_ID])),
+  planEntityIds: t.array(PLAN_ENTITY_ID),
   entityPrototypeId: ENTITY_PROTOTYPE_ID,
 });